On Thu, 2018-01-25 at 11:34 +0800, Dmitry Timoshkov wrote:
diff --git a/dlls/kerberos/krb5_ap.c b/dlls/kerberos/krb5_ap.c index ba89806957..66c795c377 100644 --- a/dlls/kerberos/krb5_ap.c +++ b/dlls/kerberos/krb5_ap.c @@ -326,7 +326,7 @@ static SECURITY_STATUS name_sspi_to_gss( const UNICODE_STRING *name_str, gss_nam static ULONG flags_isc_req_to_gss( ULONG flags ) {
- ULONG ret = GSS_C_DCE_STYLE;
- ULONG ret = 0;
if (flags & ISC_REQ_DELEGATE) ret |= GSS_C_DELEG_FLAG; if (flags & ISC_REQ_MUTUAL_AUTH) ret |= GSS_C_MUTUAL_FLAG; if (flags & ISC_REQ_REPLAY_DETECT) ret |= GSS_C_REPLAY_FLAG;
This breaks my tests:
0009:trace:secur32:EncryptMessage 0x32fca0 0 0x32fc64 0 0009:trace:secur32:lsa_EncryptMessage 0x1307f8 0 0x32fc64 0) 0009:trace:kerberos:kerberos_SpSealMessage (7cef1cb8 0x00000000 0x32fc64 0) 0009:trace:kerberos:kerberos_SpSealMessage gss_wrap_iov returned 000d0000 minor status 00000016 0009:fixme:kerberos:status_gss_to_sspi couldn't convert status 0x000d0000 to SECURITY_STATUS kerberos.c:309: Test failed: got 80090304 kerberos.c:312: Test failed: wrong data kerberos.c:315: Test failed: got 12000 kerberos.c:316: Test failed: buffer not modified 0009:trace:secur32:DecryptMessage 0x32fccc 0x32fc64 0 (nil) 0009:trace:secur32:lsa_DecryptMessage 0x136608 0x32fc64 0 (nil)) 0009:trace:kerberos:kerberos_SpUnsealMessage (7ced5de8 0x32fc64 0 (nil)) kerberos.c:319: Test failed: got 80090301 0009:trace:secur32:MakeSignature 0x32fca0 0 0x32fc64 0 0009:trace:secur32:lsa_MakeSignature 0x1307f8 0 0x32fc64 0) 0009:trace:kerberos:kerberos_SpMakeSignature (7cef1cb8 0x00000000 0x32fc64 0) 0009:trace:kerberos:kerberos_SpMakeSignature gss_get_mic returned 00000000 minor status 00000000 kerberos.c:342: Test succeeded inside todo block: got 37 0009:trace:secur32:VerifySignature 0x32fccc 0x32fc64 0 (nil) 0009:trace:secur32:lsa_VerifySignature 0x136608 0x32fc64 0 (nil)) 0009:trace:kerberos:kerberos_SpVerifySignature (7ced5de8 0x32fc64 0 (nil)) 0009:trace:kerberos:kerberos_SpVerifySignature gss_verify_mic returned 00000000 minor status 00000000 0009:trace:secur32:DeleteSecurityContext 0x32fca0 0009:trace:secur32:lsa_DeleteSecurityContext 0x1307f8 0009:trace:kerberos:kerberos_SpDeleteContext (7cef1cb8) 0009:trace:kerberos:kerberos_SpDeleteContext gss_delete_sec_context returned 00000000 minor status 00000000 0009:trace:secur32:DeleteSecurityContext 0x32fccc 0009:trace:secur32:lsa_DeleteSecurityContext 0x136608 0009:trace:kerberos:kerberos_SpDeleteContext (7ced5de8) 0009:trace:kerberos:kerberos_SpDeleteContext gss_delete_sec_context returned 00000000 minor status 00000000 0009:trace:secur32:FreeCredentialsHandle 0x32fc98 0009:trace:secur32:lsa_FreeCredentialsHandle 0x12a1b0 0009:trace:kerberos:kerberos_SpFreeCredentialsHandle (7ceec378) 0009:trace:kerberos:kerberos_SpFreeCredentialsHandle gss_release_cred returned 00000000 minor status 00000000 0009:trace:secur32:FreeCredentialsHandle 0x32fcc4 0009:trace:secur32:lsa_FreeCredentialsHandle 0x1307e0 0009:trace:kerberos:kerberos_SpFreeCredentialsHandle (7cee9dc0) 0009:trace:kerberos:kerberos_SpFreeCredentialsHandle gss_release_cred returned 00000000 minor status 00000000 Makefile:187: recipe for target 'kerberos.ok' failed make: *** [kerberos.ok] Error 7