-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
They look quite good: One suggestion though: Do you need the separate implementations for IDirect3DRM1 and IDirect3DRM3? It seems that you could thunk d3drm2 and d3drm3 to d3drm1 and work with just one implementation. That works because you don't need a separate way to create the device like you do in the cases where you create the immediate mode device yourself.
Yeah, I know that the thunk direction would be different from the other methods, but I think that's something we can live with. The thunk direction is forced by the IM device QI limitations and thunking is preferred over code duplication if it's possible.
However, there's one thing you need to test first: can you QI IDirect3DRMDevice3 from IDirect3DRMDevice(1)? Or do D3DRM Devices have the same kind of restriction (down-QI'ing only) as IM devices?
Cheers, Stefan
Am 2015-08-08 um 00:20 schrieb Aaryaman Vasishta:
Attached is the patches for implementing CreateDeviceFromD3D. Please take a look and provide feedback, if any.
Thank you! Aaryaman