Re: [PATCH v2] msacm32: Rewrite PCM conversion functions.

[Andrew Eikum]

On Wed, Jun 14, 2017 at 11:13:21AM -0500, Zebediah Figura wrote:
> On 06/14/2017 08:42 AM, Andrew Eikum wrote:
> > I really dislike complicated preprocessor tricks. Can't this be done
> > in a similar way with real functions? If not, I'd rather have the
> > copy-pasted code than these difficult macros.
> >
> > Andrew
>
> As far as I know there's no way to keep this structure without either using
> macros or rewriting the same function 20 times, neither of which is very
> desirable. On the other hand, might it be worth sacrificing a slight bit of
> efficiency (which may not even be that much) as in the attached patch?

I haven't totally reviewed this yet, but yeah, I like this far better.

Andrew