On 9 September 2018 at 19:14, Tobias Klausmann tobias.johannes.klausmann@mni.thm.de wrote:
On 09.09.18 15:33, Henri Verbeet wrote:
The latter, mostly. I think changing e.g. AOFFIMMI_U_SHIFT/AOFFIMMI_U_MASK to AOFFIMMI_U_BIT_LOW/AOFFIMMI_U_BIT_HIGH is gratuitous.
Looking a little more closely at the patch though, you're not really parsing the RESOURCE_DIM and RESOURCE_RETURN_TYPE modifiers either, so I think a FIXME would still be appropriate there. So both, I guess.
Actually i would prefer keeping the bit extract thingy, as it seems more straight forward to me in these cases. If you worry about consistency, converting more of would be a thing i could do!
Consistency is the primary concern, yes. I'm also not all that convinced about the merits of that particular change though—it seems largely a matter of personal preference. I could be convinced if you were a major contributor to the code in question, but not on your first patch I'm afraid.