Re: [PATCH v7 08/11] jscript: Get rid of the value_prop from jsdisp props.

[Jacek Caban]

Hi Gabriel,

On 11/24/21 3:10 PM, Gabriel Ivăncescu wrote:
> @@ -2088,7 +2081,10 @@ HRESULT disp_call(script_ctx_t *ctx, IDispatch *disp, DISPID id, WORD flags, uns
>       if(ctx != jsdisp->ctx)
>           flags &= ~DISPATCH_JSCRIPT_INTERNAL_MASK;
> -
>    hres = jsdisp_call(jsdisp, id, flags, argc, argv, ret);
> -
>    if(id == DISPID_VALUE)
> -
>        hres = jsdisp_call_value(jsdisp, to_disp(jsdisp), flags, argc, argv, ret);
> -
>    else
> -
>        hres = jsdisp_call(jsdisp, id, flags, argc, argv, ret);

Why do we need it here? Do we ever call disp_call(DISPID_VALUE)?

Also, with your implementation, get_prop(DISPID_VALUE) works because of 
integer overflow, but it would be nice to restructure it to not depend 
on that.

Thanks,

Jaeck