Re: [PATCH v2 3/4] winegstreamer: Implement ::Process(Input/Output) for audio conversion transform.

[Zebediah Figura (she/her)]

On 12/1/20 2:54 PM, Derek Lesho wrote:
> > > +    /* audioconvert needs a valid channel-mask */
> >
> > Well, that's not quite true, at least from my reading of the source, but
> > it does need a valid channel mask for configurations other than mono or
> > stereo.
> >
> > The code below is confusing, though; I'm not sure why channel-mask would
> > be present in the caps at all.
>
> Via MF_MT_AUDIO_CHANNEL_MASK.

Indeed, I missed that, sorry.
> > Note that a simpler way to set the channel mask is to use
> > gst_audio_info_to_caps() in caps_from_mf_media_type().
>
> Mind if I just move this functionality to caps_from_mf_media_type? I
> remember having problems with gst_audio_info_to_caps.

I don't think that makes very much sense in general, no. What problems
did you have with gst_audio_info_to_caps()?