Re: [PATCH] rpcrt4: Use wide-char string literals.

[Michael Stefaniuc]

This seems to be a pre-existing issue as I get the same test failures with the
no-op change:

--- a/dlls/rpcrt4/tests/server.c
+++ b/dlls/rpcrt4/tests/server.c
@@ -245,8 +245,8 @@ static void (__cdecl *test_handle)(ctx_handle_t ctx_handle);
 /* type check statements generated in header file */
 fnprintf *p_printf = printf;

-static const WCHAR helloW[] = { 'H','e','l','l','o',0 };
-static const WCHAR worldW[] = { 'W','o','r','l','d','!',0 };
+static const WCHAR helloW[] = L"Hello";
+static const WCHAR worldW[] = L"World!";

static BOOL is_interp;

https://testbot.winehq.org/JobDetails.pl?Key=82694

bye
    michael

On 11/28/20 11:18 PM, Marvin wrote:
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
>
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=82684
>
> Your paranoid android.
>
> === w1064 (32 bit report) ===
>
> rpcrt4:
> 06b4:server: unhandled exception 000006be at 75A89AB2
>
> === w1064_2qxl (64 bit report) ===
>
> rpcrt4:
> server.c:2178: Test failed: RpcBindingFree
>
> === w10pro64 (64 bit report) ===
>
> rpcrt4:
> server.c:2178: Test failed: RpcBindingFree
>
> === w10pro64_ar (64 bit report) ===
>
> rpcrt4:
> server.c:2178: Test failed: RpcBindingFree
>
> === w10pro64_he (64 bit report) ===
>
> rpcrt4:
> server.c:2178: Test failed: RpcBindingFree
>
> === w10pro64_zh_CN (64 bit report) ===
>
> rpcrt4:
> server.c:2178: Test failed: RpcBindingFree