On Friday 27 December 2002 04:35 am, Gerald Pfeifer wrote:
On Thu, 26 Dec 2002, Greg Turner wrote:
If we really want to use off_t in this file (instead of cab_off_t) we need to #include sys/types.h, or we'll break non-Linux systems.
actually I don't think we really want to use off_t. [...] The easy version of the right fix is probably just to rename "cab_off_t" to something less confusing (i.e., cab_file_offset). The fancy fix would be to support huge files, which might be a bit of a project.
Ah, I see.
Short to medium term, do you agree with my fix (#include <sys/types.h>) so that Wine also builds on non-Linux systems?
Gerald
Maybe. I don't object, since it should be harmless to add this, but I seem to be missing the point of why sys/types.h is needed at all. cab_off_t is just typedef'ed to UINT32, which should compile just fine with only winnt.h, I think. Is there a particular scenario you are encountering that fails? If so, what is the compile error?