On 23 Jul 2014, at 07:57, Jactry Zeng wrote:
Hi, 2014-07-22 18:36 GMT+08:00 Huw Davies huw@codeweavers.com:
Before you start implementing the ITextSelection methods, have you thought about how the ITextRange returned by ITextDocument::GetStoryRanges would work?
Do you mean ITextRange returned by ITextDocument::Range? ITextRange is returned by ITextDocument::Range and MS's Text Object Model didn't implement ITextDocument::GetStoryRanges.[0]
Yes, sorry, I meant ITextDocument:Range.
It seems to me it would be useful to have a text range object that could be used by both, rather than implementing two lots of ITextRange methods.
I would like to write some helper functions(such as ME_ITextGetText and ME_ITextGetChar) and share them between ITextSelection and ITextRange. https://github.com/Jactry/wine/commit/91e4f9f1510cb71c3c5afe4bf9e4bc8cb6b438...
Using helpers is fine too. Though I don't like the name, range_GetText might be better.
Huw.