Re: [PATCH 1/2] ieframe: Added default action implementation for IDocHostUIHandler::GetExternal

[Nikolay Sivov]

On 5/16/2012 14:21, Jacek Caban wrote:
> dlls/ieframe/Makefile.in     |    1 +
>   dlls/ieframe/dochost.c       |   16 ++-
>   dlls/ieframe/ieframe.h       |    2 +
>   dlls/ieframe/shelluihelper.c |  378
> ++++++++++++++++++++++++++++++++++++++++++
>   4 files changed, 395 insertions(+), 2 deletions(-)
>   create mode 100644 dlls/ieframe/shelluihelper.c
> +*ppDispatch = (IDispatch*)This->shell_ui_helper;
> - IDispatch_AddRef(*ppDispatch);
> - return S_OK;

IShellUIHelper2 supports IDispatch, so these three lines and a cast 
could be replaced with one QI like:

return IShellUIHelper2_QueryInterface(This->shell_ui_helper,&IID_IDispatch, (void**)ppDispatch);

if I'm not missing something.