On Tue, Sep 2, 2008 at 12:55 AM, Paul Vriens paul.vriens.wine@gmail.com wrote:
James Hawkins wrote:
On Tue, Sep 2, 2008 at 12:45 AM, Paul Vriens paul.vriens.wine@gmail.com wrote:
James Hawkins wrote:
On Mon, Sep 1, 2008 at 8:08 PM, James Mckenzie jjmckenzie51@earthlink.net wrote:
One file per run is all that should be created, IMHO.
No, zero log files should be created. This discussion is about reducing the time it takes to run the tests, and any logging hinders that effort.
OK, back to the initial discussion then.
I did find that 'System Restore' was the cause of the slowdown on a lot of (at least) XP and Vista systems. Patches are being sent for that.
Disabling logging as I suggested at first only helps to get rid of a few seconds from the total run time of these tests. The question remains however why some people have loads of log files in their temp directory and some don't.
Do you think that for testing purposes we could add a check in the install tests that shows us the number of MSI logfiles in the temp directory before and afterwards? Or is it enough that several people already responded to my question about those logfiles?
It's not worth messing with. The slowdown is because of the restore points, and that has been solved, so hopefully the patches will be accepted and we won't have any timeouts. On my Server 2008 system, logs are created that usually contain just one line about whatever error was being tested. I haven't tested whether MsiEnableLog affects that, but my guess is it doesn't. Either way, those are just one line log files in a temp directory.
So we can say that logfiles are created, although they only contain 1 line per logfile (this is the same on my boxes).
I did test with MsiEnableLog and it does effect the creation of these files.
I'm in favor of using MsiEnableLog to create just one logfile in the temp directory. It doesn't need to be removed as it could be used for all kinds of other purposes. I do like it however that there are hardly leftovers after running winetest.
If MsiEnableLog has any affect, and people are bothered by small log files in a temp directory, then all you need is one call to MsiEnableLog in the beginning of the tests to disable logging.
/* disable logging */ MsiEnableLog(0, NULL, 0);