Re: [PATCH 1/2] quartz/videorenderer: Get rid of CreateRenderingSubsystem().

[Chip Davis]

October 17, 2019 11:17 PM, "Zebediah Figura"  wrote:
> diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c
> index 87365d9212..f4d6945380 100644
> --- a/dlls/quartz/videorenderer.c
> +++ b/dlls/quartz/videorenderer.c
> @@ -873,8 +858,11 @@ HRESULT VideoRenderer_create(IUnknown *outer, void **out)
>      if (FAILED(hr))
>          goto fail;
> - if (!CreateRenderingSubsystem(pVideoRenderer)) {
> -
>    hr = E_FAIL;
> - pVideoRenderer->hEvent = CreateEventW(NULL, TRUE, FALSE, NULL);
> -
> - if (FAILED(BaseWindowImpl_PrepareWindow(&pVideoRenderer->baseControlWindow.baseWindow)))

I think you want to set 'hr' here.
> - {
> -
>    CloseHandle(pVideoRenderer->hEvent);
>    goto fail;
> }
>
> -- 
> 2.23.0

Chip