Thanks, I’ll address these in v2, just one point.
On 9 Sep 2021, at 18:55, Henri Verbeet hverbeet@gmail.com wrote: I assume we're ending the current render pass (if any) for vkCmdCopyBufferToImage(). In principle wined3d_context_vk_image_barrier() already takes care of that, but I suppose it makes sense to be explicit about it. Perhaps it wouldn't hurt to add a comment mentioning the reason we need to end the render pass; I didn't add those for the existing instances of wined3d_context_vk_end_current_render_pass(), and that may have been a mistake. In any case, this too is somewhat of an independent change.
Actually it’s for the vkCmdPipelineBarrier() call, so not really independent. But yeah, I put it early in the function for the extra explicitness - I’ll add the comment.
- Jan