Re: Third listview status update

[Rein Klazes]

On Tue, 22 Oct 2002 23:59:28 -0400, you wrote:
> On October 22, 2002 11:45 pm, Rein Klazes wrote:
> > On Tue, 22 Oct 2002 19:38:41 -0400, you wrote:
> > > The line numbers look strage. What version of
> > > dlls/comctl32/comctl32undoc.c did you run it with?
> >
> > rev 1.71, latest cvs.
>
> Interesting. Listen, can you please retry with _all_ my
> latest patches, there were 2 very serious bugs that
> might have caused those problems, in some strange ways.

That seems to solve it, no crashes for a while. Needs a lot longer
testing to 100% sure though.

Here is a patch that solves the r1.200 regression:
===============
--- listview.w6.c	2002-10-23 08:38:12.000000000 +0200
+++ listview.c	2002-10-23 08:40:53.000000000 +0200
@@ -4453,8 +4453,13 @@
         lvItem.iSubItem = 0;
         if (!LISTVIEW_GetItemW(infoPtr, &lvItem)) continue;

-	if (lvItem.mask & LVIF_PARAM && lpFindInfo->lParam ==
lvItem.lParam)
-	    return nItem;
+	if (lvItem.mask & LVIF_PARAM)
+        {
+            if (lpFindInfo->lParam == lvItem.lParam)
+                return nItem;
+            else
+                continue;
+        }
    
         if (lvItem.mask & LVIF_TEXT)
    {
============

Rein.