Stefan Dösinger stefan@codeweavers.com writes:
To stay on topic though, I oppose moving the lock into every state handler. There are just the scissorrect and viewport functions that may have to perform User32 calls(if the patch turns out to be correct). Moving the lock call into the state handlers would pollute the code with them and raise the locking costs considerably.
It would require adding more of them, but that's good, it makes the locking more explicit. We really have to stop taking a big global lock and executing thousands of lines of code inside it. As long as you are only moving the lock inside the individual functions the cost is the same.