RE: UI bugs hampering porting effort for shaped window

[Rob]

Hi Mike,

bug 1541 is still *not* fixed correctly. See when passing in NULL in windows
to gethostbyname, it is guarenteed to return a list of local IP addresses
mapped on the box. However, with WINE, passing NULL causes gethostname to be
passed into gethostbyname and does *not* always return back the list of
local IP addresses on the box. This may work on some boxes, and not others,
depending on how the machine is configured and if the DNS lookup on the host
name resolves to the local IP addresses.

File: dlls/winsock/socket.c

static WIN_hostent * __ws_gethostbyname(const char *name, int dup_flag)
{
    WIN_hostent *retval = NULL;
    struct hostent*     host;
#ifdef  HAVE_LINUX_GETHOSTBYNAME_R_6
    char *extrabuf;
    int ebufsize=1024;
    struct hostent hostentry;
    int locerr = ENOBUFS;
#endif
    char buf[100];
    if( !name) {
        name = buf;
        if( gethostname( buf, 100) == -1) {
            SetLastError( WSAENOBUFS); /* appropriate ? */
            return retval;
        }
    }

whereas if (!name) should use SIOCGIFCONF - SIOCGIFADDR or something...

Jerry's patch *does* fix the UI issues actually - B1 through B4 - any idea
why it isn't applied to the CVS tree? We have the version out of CVS, which
definately has issues with B1-B4.

B5 is still broken, but not critical.

B6 is confirmed fixed now with CVS build.

B7 is still broken, but it's not critical as we have a work around solution.

-Rob

-----Original Message-----
From: [e-mail] [mailto:[e-mail]]On
Behalf Of Mike Hearn
Sent: October 30, 2003 1:22 AM
To: [e-mail]
Subject: Re: UI bugs hampering porting effort for shaped window

On Wed, 29 Oct 2003 16:59:59 -0800, Sir Rob scribed thus:
> Bugzilla Bug 1541
>    WS2_32 version of gethostbyname with NULL argument doesn't follow
> specification
> http://bugs.winehq.org/show_bug.cgi?id=1541

[mike@littlegreen working]$ cvs log -N -r1.135 dlls/winsock/socket.c
RCS file: /home/wine/wine/dlls/winsock/socket.c,v
Working file: dlls/winsock/socket.c
head: 1.138
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 138;   selected revisions: 1
description:
----------------------------
revision 1.135
date: 2003/09/02 18:12:20;  author: julliard;  state: Exp;  lines: +10 -0
Rein Klazes 
_ws_gethostbyname() and WSAAsyncGetHostByName() when called with a
null name, should use the name returned by gethostname().
============================================================================
=

What version of Wine were you using? It seems this bug was fixed some time
ago, we just forgot to update bugzilla.
> B1, B2, B3, and B4 can be fixed by putting a title bar on the application.
> (See MAKE_IT_LOOK_LIKE_A_NORMAL_APP_AT_STARTUP in winetest.cpp.)

Yes they are caused by our use of override-redirect, which causes a LOT of
bug reports. I can't remember why Jerrys patch was not applied, but I
think Alexandre has very specific ideas about what to do in this area.
> - B6. Copy to the clipboard doesn't work (though pasting from the

clipboard
>   does work).

What does a +clipboard trace show? Does the demo app show this?
> - B7. Attempting to bring up the right-click context menu causes the app

to
>   hang.

Does the demo app show this? If so, perhaps one of us can get a backtrace
of the deadlock.

thanks -mike