On Tuesday 02 January 2007 19:42, * * wrote:
StringAnalysis should have a cache object, not save the HDC directly.
I agree, although you shouldn't free the cache in ScriptStringFree, the caller is responsible for that.
One of the important things about the cache, which wine currently doesn't do, is that the caller is free to select a different font into the HDC after calling ScriptStringAnalyse and Uniscribe is supposed to use the right one.
Yes, cache handling is still very basic. If the font changes the cache should be invalidated. It also needs to be ref counted and locked.
-Hans