Re: [PATCH v3 4/5] vbscript: Implement separate script dispatch objects for each named item.

[Jacek Caban]

Hi Gabriel,

It looks much better now. I can't do full review until we resolve the 
issue from the other mail, so below is just one thing I spotted already.

On 05.02.2020 17:38, Gabriel Ivăncescu wrote:
> @@ -196,7 +196,7 @@ named_item_t *lookup_named_item(script_ctx_t *ctx, const WCHAR *name, unsigned f
>   LIST_FOR_EACH_ENTRY(item, &ctx->named_items, named_item_t, entry) {
>       if((item->flags & flags) == flags && !wcsicmp(item->name, name)) {
> -
>        if(!item->disp) {
> -
>        if(!item->disp && !(item->flags & SCRIPTITEM_CODEONLY)) {

This deserves a separated patch, preferably with a test (and ideally 
with a test in the same patch as the fix; I generally don't mind sending 
large set of tests in a single patch for large features like the whole 
patch series, but for isolated issues with a small fix it makes 
reviewing much nicer if I can see a test without going searching it in a 
large test patch).

Thanks,

Jacek