Re: [PATCH] vbscript: support for class default sub.

[Jacek Caban]

Hi Robert,

On 06.10.2020 23:14, Robert Wilhelm wrote:
> diff --git a/dlls/vbscript/vbscript.h b/dlls/vbscript/vbscript.h
> index 869fb05b6ed..1f4132b1898 100644
> --- a/dlls/vbscript/vbscript.h
> +++ b/dlls/vbscript/vbscript.h
> @@ -314,7 +314,9 @@ typedef enum {
>       FUNC_PROPGET,
>       FUNC_PROPLET,
>       FUNC_PROPSET,
> - FUNC_DEFGET
> - FUNC_DEFGET,
> - FUNC_DEFFUNC,
> - FUNC_DEFSUB
> } function_type_t;

With your patch, 'default' is no longer a separated function type but 
rather a function flag. I'd expect that if you express that in data 
types, the implementation will be more straightforward. I'd suggest to 
get rid of FUNC_DEFGET and store the information about 'default' in 
function_decl_t (something like a new is_default flag or change 
is_public to (public,private,default) enum; I'm not sure without trying).

Is it possible to have both default getter and sub/function in the same 
class? Some tests around that would be interesting.

Thanks,

Jacek