Re: [PATCH] msvcp100: Add Concurrency::_GetCombinableSize stub.

[Piotr Caban]

Hi Gijs,

On 07/18/18 01:49, Gijs Vermeulen wrote:
> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41419

This patch is causing the application to run into another unimplemented 
function (??0_ReaderWriterLock@details@Concurrency@@QAE@XZ). Because of 
that it's hard to say if such a stub is working. The value returned by 
_GetCombinableSize is used later in malloc and memset. I bet that the 
application will crash later trying to access/modify the memory. We 
should probably at least return 11 in the stub (this is what the 
function returns if a simple test is written).

I don't think we want to add a stub for function that we don't 
understand unless it lets the application run.

Thanks,
Piotr