2016-11-06 22:30 GMT+01:00 Nikolay Sivov bunglehead@gmail.com:
On 07.11.2016 0:23, Matteo Bruni wrote:
2016-11-06 19:45 GMT+01:00 Nikolay Sivov nsivov@codeweavers.com:
+static HRESULT WINAPI memorydataloader_Decompress(ID3DX10DataLoader *iface, void **data, SIZE_T *size) +{
- struct asyncdataloader *loader = impl_from_ID3DX10DataLoader(iface);
- FIXME("loader %p, data %p, size %p semi-stub\n", loader, data, size);
- *data = loader->data;
- *size = loader->size;
- return S_OK;
+}
Why the fixme? What's still missing here?
My understanding is that it should detect certain types of compression and actually decompress if needed.
Ah, I guess that's possible. I assumed the method to be there only for custom ID3DX10DataLoader implementations but that's not necessarily the case. I'd just manually check if loading a .zip file (and maybe some other compressed format) with the file loader does return the compressed or the uncompressed data and either change the FIXME with a plain TRACE or add a small comment about the supported compressed formats you found.