On Wed, Feb 18, 2009 at 5:20 AM, Francois Gouget fgouget@free.fr wrote:
My remark was not so much about including windows.h rather than winfoo.h, but about including it in winetest.h when the parent C file has already included the winxxx.h files it needs. That is, in Wine it seems we have a policy to put include statements primarily in the C files, rather than in private header files.
Also:
- I don't see what depends on windows.h in winietest.h (besides my
newly added annotations).
- if I remember correctly, removing this include did not cause any
warning or compilation error (even with my newly added annotations). But maybe it's different if you compile with MinGW or MSVC (in which case Wine's headers should be fixed).
Right, I don't disagree with the change, I was more just thinking out loud. I agree it does not need to be in that header, I just think we should not avoid using windows.h in the programs.
Thanks