Re: [PATCH v3 4/5] dlls/kernelbase: handle corner case in CreateProcess

[Jacek Caban]

Hi Eric,

On 2/17/22 10:10, Eric Pouech wrote:
> diff --git a/programs/services/services.c b/programs/services/services.c
> index 87ab319367b..2edc02d300c 100644
> --- a/programs/services/services.c
> +++ b/programs/services/services.c
> @@ -1094,7 +1094,7 @@ found:
>       process->use_count++;
>       service_unlock(service_entry);
> - r = CreateProcessW(NULL, path, NULL, NULL, FALSE, CREATE_UNICODE_ENVIRONMENT, environment, NULL, &si, &pi);
> - r = CreateProcessW(NULL, path, NULL, NULL, FALSE, CREATE_UNICODE_ENVIRONMENT | DETACHED_PROCESS, environment, NULL, &si, &pi);
>  HeapFree(GetProcessHeap(), 0, path);
>  if (!r)
>  {

This probably deserves a separated patch.

Thanks,

Jacek