On 2/1/22 22:16, Dmitry Timoshkov wrote:
Nikolay Sivov nsivov@codeweavers.com wrote:
It looks like assigning a reviewer for a patch doesn't work very well. Can the situation be improved somehow? Is there any responsibility of a reviewer for ignoring the assigment?
Since this is exactly the same as the original patches, same concerns expressed initially apply for it as well.
I didn't see any real concern. Could you please try to be more specific?
Everything that I mentioned before - using windows-specific font name both for tests and code changes for no good reason, especially since user won't have it installed; char ranges picked rather arbitrarily with no explanation.
I'm planning to work on this, unfortunately can't give exact time frame when it will be done.
I already suggested a solution for a bunch of real world WPF applications that rely on this behaviour: the test shows exactly what's the problem, and the patch provides the fix. What's wrong with this approach? What would you suggest to do instead?
I don't know yet, it's one of those things that you have to spend more time on. For now I'd suggest to use your fix locally, if it works for you.