Re: [PATCH 1/7] ntdll: Implement RtlGetSystemTimePrecise().

[Huw Davies]

On Thu, May 02, 2019 at 08:55:39AM -0500, Ken Thomases wrote:
> On May 2, 2019, at 3:45 AM, Huw Davies  wrote:
> > +/***********************************************************************
> > -
> > -
> >   RtlGetSystemTimePrecise [NTDLL.@]
> > -
> > -
> > -
> > - Get a more accurate current system time.
> > -
> > -
> > -
> > - RETURNS
> > -
> > - The current system time.
> > - */
> >
> > +LONGLONG WINAPI RtlGetSystemTimePrecise( void )
> > +{
> > - LONGLONG time;
> > -
> >
> > +#if defined(HAVE_CLOCK_GETTIME)
> > - struct timespec ts;
> > -
> > - if (!clock_gettime( CLOCK_REALTIME, &ts ))
> > - {
> > -
> >    time = ts.tv_sec * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970;
> > -
> >    time += (ts.tv_nsec + 50) / 100;
> > - }
> > - else
> >
> > +#endif
>
> Using clock_gettime() on macOS is a bit problematic because of
> backward deployment and weak linking.  See
> <https://source.winehq.org/git/wine.git/commit/27c71e09ad51ba6aa672a46379efd1...
> although that's not necessarily my preferred approach.  (I wanted to
> check if it was available at run-time and use it, if so.  Alexandre
> didn't like that.)

Gah, how annoying!  Perhaps we should disable the HAVE_CLOCK_GETTIME configure test
on macOS in that case?

Huw.