Re: [PATCH vkd3d 07/12] vkd3d-shader/hlsl: Support matrix indexing.

[Giovanni Mascellani]

Hi,

Il 20/04/22 15:57, Matteo Bruni ha scritto:
> > - ret_type = hlsl_get_vector_type(ctx, mat_type->base_type, mat_type->dimx);
> > - scal_type = hlsl_get_scalar_type(ctx, mat_type->base_type);
>
> Nitpick, might as well name it scalar_type.

Ok, if you're sending another patch set feel free to change it. 
Otherwise I'll address that in a later patch.
> > -
> > - sprintf(name, "<index-%x>", counter++);
>
> I know that char name[32] is certainly going to be enough here, but
> I'd prefer if we always used vkd3d_string_buffer for this kind of
> temporary strings, going forward.

Same here.

Giovanni.