Re: [PATCH] wined3d: Implement per-stage constant in glsl fixed fonction pipeline.

[Henri Verbeet]

On 24 June 2013 16:44, Matteo Bruni  wrote:
> @@ -1673,6 +1673,8 @@ struct texture_stage_op
>      unsigned                aarg2 : 8;
>      unsigned                aarg0 : 8;
> - DWORD                   constant;
> - struct color_fixup_desc color_fixup;
>    unsigned                tex_type : 3;
>    unsigned                dst : 1;
>
> You don't need this if you use uniforms.
> Also adding a test would be nice probably.

Yeah, that's the main issue. We don't want a shader for every possible
set of per-stage constant values. The one you missed is that if we
implement this, we should also set the appropriate caps bit.

The most obvious issue is of course the subject line. Sure, typos
happen, but it's just plain sloppy. At least try to pretend you put
some effort into making sure the patch is as good as it can be before
submitting it.