Re: [PATCH] [include] Add IWbemContext and IWebCallResult interface and other class definitions

[Vijay Kiran Kamuju]

On Wed, Jan 1, 2020 at 4:15 PM Nikolay Sivov  wrote:
> On 1/1/20 5:27 PM, Vijay Kiran Kamuju wrote:
> > On Wed, Jan 1, 2020 at 2:30 PM Marvin  wrote:
> > > Hi,
> > >
> > > While running your changed tests, I think I found new failures.
> > > Being a bot and all I'm not very good at pattern recognition, so I might be
> > > wrong, but could you please double-check?
> > >
> > > Full results can be found at:
> > > https://testbot.winehq.org/JobDetails.pl?Key=62711
> > >
> > > Your paranoid android.
> > >
> > > === debian10 (build log) ===
> > >
> > > ../../wine/include/wbemcli.idl:348: error: syntax error, unexpected '*', expecting ')'
> > > Task: The win32 build failed
> > >
> > > === debian10 (build log) ===
> > >
> > > ../../wine/include/wbemcli.idl:348: error: syntax error, unexpected '*', expecting ')'
> > > Task: The wow64 build failed
> >
> > The failures are due to wild unable to parse the SAFEARRAY(BSTR *)
> > *pStr; declarations in idl files.
> > Can anyone help with widl parser fixes for this.
> > as the declaration in parser.y is like below:
> > tSAFEARRAY '(' type ')'               { $$ = make_safearray($3); }
>
> Your definition is wrong, it should be 'SAFEARRAY(BSTR) *'.It's also
> missing interface attributes, and has a typo in patch subject.
>
> P.S. please try to build patches you're submitting.

Could not build the patches on cygwin, I forgot to submit to testbot
to check the correctness of the patch.
Sent corrected version of the patch, I was checking the midl generated
header file from SDK for the SAFEARRAY declarations.

--
Thanks,
Vijay