Re: [PATCH v2 1/4] ddraw: Don't write out if a ddraw1 surface of size 0 is requested.

[Henri Verbeet]

On 27 January 2017 at 19:21, Alex Henrie  wrote:
> 2017-01-27 5:43 GMT-07:00 Henri Verbeet :
> > Where does this pass without the broken()? It writes NULL to surface
> > for me on Windows 7, and appears to handle the exception when an
> > invalid pointer is passed in.
>
> http://testbot.winehq.org/JobDetails.pl?Key=28086
>
> The following testbot VMs are the only ones that zero out the surface pointer:
>
> w8 (32 bit ddraw1)
> w864 (32 bit ddraw1)
> w1064 (32 bit ddraw1)
>
> Maybe the behavior of newer versions of Windows depends on the video
> card driver?

Those are the only testbot VMs where the test gets run.
test_surface_qi() requires D3D, and that's only supported on the
Windows 8 and higher VMs. 64-bit ddraw doesn't support D3D at all.