On 10/1/2014 16:35, Joachim Priesner wrote:
+#include <stdarg.h> +#include <string.h>
+#include "comctl32.h" +#include "shlwapi.h"
+#include "windef.h" +#include "winbase.h" +#include "wingdi.h" +#include "winternl.h" +#include "dlgs.h" +#include "wine/debug.h" +#include "wine/unicode.h"
It's unlikely you need all of those.
I'll need them for patch 2 of 3 though, and wanted to balance the size of the patches. Shall I move them to the later patch?
That said, if I resend the patches: Do patches in a series have to retain all functionality when applied on their own? If not, I could make the patch smaller by not moving the old TaskDialogIndirect implementation to the new file, but creating a stub instead.
+#define TD_WARNING_ICON MAKEINTRESOURCEW(-1) +#define TD_ERROR_ICON MAKEINTRESOURCEW(-2) +#define TD_INFORMATION_ICON MAKEINTRESOURCEW(-3) +#define TD_SHIELD_ICON MAKEINTRESOURCEW(-4)
Where this comes from? I mean particular id values.
Those are the definitions from Windows' CommCtrl.h. Is it okay to use these directly or do I have to write a test program that prints the value of these constants (and get the same results)?
P.S. On a general note I forgot to add: This patch is heavily based on dlls/user32/msgbox.c.