Re: [PATCH] bcrypt: Added stub implementation for BCryptGetFipsAlgorithmMode

[Dmitry Timoshkov]

Kai Blaschke  wrote:
> diff --git a/dlls/bcrypt/tests/Makefile.in b/dlls/bcrypt/tests/Makefile.in
> new file mode 100644
> index 0000000..363986e
> --- /dev/null
> +++ b/dlls/bcrypt/tests/Makefile.in
> @@ -0,0 +1,5 @@
> +TESTDLL   = bcrypt.dll
> +IMPORTS   = user32 gdi32 bcrypt

user32 and gdi32 APIs are not used in the test and should be removed
from the imports list.
> +static void test_getFipsAlgorithmMode(void)
> +{
> - BOOLEAN result = TRUE;
> - NTSTATUS status = BCryptGetFipsAlgorithmMode(&result);
> - ok(!status, "expected status STATUS_SUCCESS(0), got %d\n", status);
> - ok(!result, "expected result FALSE, got %d\n", result);
>
> +}

Probably BCryptGetFipsAlgorithmMode should be loaded dynamically.
A usual test for invalid (NULL) argument would be useful. Also
status should be printed in hex to match ntstatus.h definitions.