Re: Menu crash - was : Re: [PATCH] Version info for comctl32.dll

[gerard patel]

At 11:44 PM 17/03/2001 -0500, you wrote:
> Strange but true.  I reverted the patch, and alt-b beeps but does not
> cause a crash.  With the patch in, wine crashes without a beep.
>
> Now I guess I'll put it back in.  It doesn't cripple me if wine crashes
> when I fat-finger the GUI.  I guess wine-devel doesn't want to see a
> trace, and maybe you don't either, but if you do it will save time to
> send it.

I had left out some cases in my first try :/, but maybe it's better to understand 
firsst what the app is doing.

Could you send me a complete (from start) +relay,+menu trace of your app crashing
with current Wine  (no copy to wine-devel is best in this case)

If you can apply the following patch to enhance trace first :

--- menu.c.orig Sun Mar 18 10:18:31 2001
+++ menu.c      Sun Mar 18 11:28:29 2001
@@ -1852,6 +1852,7 @@
     LPWSTR prevText = IS_STRING_ITEM(item->fType) ? item->text : NULL;

debug_print_menuitem("MENU_SetItemData from: ", item, "");
+    TRACE("flags=%x str=%p\n", flags, str);

if (IS_STRING_ITEM(flags))
     {
@@ -4511,6 +4512,9 @@
 {
     if (!menu) return FALSE;

+    debug_print_menuitem("MENU_SetItemInfo_common from: ", menu, "");
+    TRACE("mask=%x type=%x text=%p\n", lpmii->fMask, lpmii->fType, lpmii->dwTypeData);
+
     if (lpmii->fMask & MIIM_TYPE ) {
        /* Get rid of old string.  */
        if ( IS_STRING_ITEM(menu->fType) && menu->text) {
@@ -4589,7 +4603,7 @@
     if (lpmii->fMask & MIIM_DATA)
        menu->dwItemData = lpmii->dwItemData;

-    debug_print_menuitem("SetMenuItemInfo_common: ", menu, "");
+    debug_print_menuitem("SetMenuItemInfo_common to : ", menu, "");
     return TRUE;
 }

Thanks.

Gerard

Menu crash - was : Re: [PATCH] Version info for comctl32.dll

On Sun, 18 Mar 2001, gerard patel wrote:
> At 11:44 PM 17/03/2001 -0500, you wrote:
> > Strange but true.  I reverted the patch, and alt-b beeps but does not
> > cause a crash.  With the patch in, wine crashes without a beep.
> >
> > Now I guess I'll put it back in.  It doesn't cripple me if wine crashes
> > when I fat-finger the GUI.  I guess wine-devel doesn't want to see a
> > trace, and maybe you don't either, but if you do it will save time to
> > send it.
>
> I had left out some cases in my first try :/, but maybe it's better to understand
> firsst what the app is doing.
>
> Could you send me a complete (from start) +relay,+menu trace of your app crashing
> with current Wine  (no copy to wine-devel is best in this case)
>
> If you can apply the following patch to enhance trace first :

Okay.  This troubles me.  AFAIK I should be current with wine-cvs.  I
even took out Dmitry's loader patch (for builtin version loading) though
that can't be anything to do with an offset in menu.c.

[whit@giftie controls]$ patch -p0 -l </gp/p04/trace
patching file menu.c
Hunk #3 succeeded at 4607 (offset 4 lines).
[whit@giftie controls]$ exit

With full +relay,+menu, wine crashes, then winedbg does, and the trace
is 181m.  It is taking a while to bzip2.  sure You wouldn't rather have
a
+menu,-relay=rtlentercriticalsection:RTLleavecriticalsection:rtldeletecriticalsection:initializecriticalsection:interlockedincrement:interlockeddecrement
?

Lawson
---cut here

________________________________________________________________
GET INTERNET ACCESS FROM JUNO!
Juno offers FREE or PREMIUM Internet access for less!
Join Juno today!  For your FREE software, visit:
http://dl.www.juno.com/get/tagj.