Alexandre Julliard wrote:
Mike Hearn mike@navi.cx writes:
Yes, I have an implementation of NdrClientCall2 in my local tree, but I'm a bit busy with other COM things at the moment. I'll send an updated patch to the list either tonight or sometime over the weekend.
Alexandre, why was this not merged when it was originally sent?
No idea, please resubmit.
IIRC Robert said that the patch isn't cleaned up yet and so it shouldn't be commited. He also said that he hasn't tested it much except for simple tests and the complex types weren't tested at all.
- Filip
Filip Navara wrote:
Alexandre Julliard wrote:
Mike Hearn mike@navi.cx writes:
Yes, I have an implementation of NdrClientCall2 in my local tree, but I'm a bit busy with other COM things at the moment. I'll send an updated patch to the list either tonight or sometime over the weekend.
Alexandre, why was this not merged when it was originally sent?
No idea, please resubmit.
IIRC Robert said that the patch isn't cleaned up yet and so it shouldn't be commited. He also said that he hasn't tested it much except for simple tests and the complex types weren't tested at all.
Since I'm trying to run an application that is in the need of NdrClientCall2, I can probably do some tests with it (but I don't know what types are being used in it).
I'm wondering when is a patch 'good enough' to be included? (both from an 'enduser', an author's point of view and from Alexandre's view (who eventually commits the patch)?
Is there an official way to track that a patch submitted to wine-patches has been comitted? Also can I somehow find out which (interesting) patches have not been comitted yet?
Also, I noticed there is currently only one person with CVS write permissions for Wine? Has this always been the case? --- Jeroen
On Fri, 30 Jul 2004 08:24:53 +0200, Jeroen Janssen wrote:
I'm wondering when is a patch 'good enough' to be included? (both from an 'enduser', an author's point of view and from Alexandre's view (who eventually commits the patch)?
Well, it really depends on the individual patch. Obviously the code itself has to be visibly free of bugs, that is mostly what peer review is about but equally a patch can be rejected if the technique it uses is too hacky, or the patch has some other problems.
Is there an official way to track that a patch submitted to wine-patches has been comitted? Also can I somehow find out which (interesting) patches have not been comitted yet?
Unfortunately there is no way to track this in an automated fashion. It has been talked about but nobody created a system yet. We just watch wine-cvs and see when it's been checked in.
Also, I noticed there is currently only one person with CVS write permissions for Wine? Has this always been the case? --- Jeroen
Yes. Before we had CVS it was like the kernel, people just mailed Alexandre patches and didn't know if they'd been merged until the next release (as far as I know, but that was long before my time, back then I thought Win98 was the bees knees ;)
Mike Hearn wrote:
Is there an official way to track that a patch submitted to wine-patches has been comitted? Also can I somehow find out which (interesting) patches have not been comitted yet?
Unfortunately there is no way to track this in an automated fashion. It has been talked about but nobody created a system yet. We just watch wine-cvs and see when it's been checked in.
Hmmm, so it can (unfortunately) happen that a patch is 'forgotten'
Also, I noticed there is currently only one person with CVS write permissions for Wine? Has this always been the case?
Yes. Before we had CVS it was like the kernel, people just mailed Alexandre patches and didn't know if they'd been merged until the next release (as far as I know, but that was long before my time, back then I thought Win98 was the bees knees ;)
Oh, well.. I actually ment to compare 'one person with CVS write permissions' to 'multiple persons with CVS write permissions'.
In the past, (open source) projects I worked on had multiple persons with CVS write access to the repository.
Related to the kernel, some people keep their 'personal' tree (like -mm, -ac, etc) that can be used to structurally test certain patches, etc and then subsequently patches can be gradially merged from these trees to the 'official main tree' (after some testing).
Is this something that also would work for wine? --- Jeroen
On Fri, 30 Jul 2004 17:48:08 +0200, Jeroen Janssen wrote:
Hmmm, so it can (unfortunately) happen that a patch is 'forgotten'
Yes that does happen sometimes. It's up to the author to resubmit it.
Alternatively sometimes a patch is correct but can't be applied for other reasons, like my lockwindowupdate patch or systray patch.
Oh, well.. I actually ment to compare 'one person with CVS write permissions' to 'multiple persons with CVS write permissions'.
In the past, (open source) projects I worked on had multiple persons with CVS write access to the repository.
That is more typical yes.
Related to the kernel, some people keep their 'personal' tree (like -mm, -ac, etc) that can be used to structurally test certain patches, etc and then subsequently patches can be gradially merged from these trees to the 'official main tree' (after some testing).
Is this something that also would work for wine? --- Jeroen
Maybe, that is what arch was all about, but it's not really mature enough to work well in Wine yet I think.
External patchsets might happen at some point, I don't know. I think most people are happy with the current system.
-
Filip Navara -
Jeroen Janssen -
Mike Hearn