[PATCH 1/3] winemac: Keep the result string in the IME UI window procedure.

[Akihiro Sagawa]

This is winemac.drv port from winex11.drv.
Please refer b8dc1e7cde64c212882958c0806b50911a360fb9.
I've not tested this code, but I believe it works.

Signed-off-by: Akihiro Sagawa 
---
 dlls/winemac.drv/ime.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

[Aric Stewart]

Signed-off-by: Aric Stewart

On 11/16/17 9:12 AM, Akihiro Sagawa wrote:
> This is winemac.drv port from winex11.drv.
> Please refer b8dc1e7cde64c212882958c0806b50911a360fb9.
> I've not tested this code, but I believe it works.
> Signed-off-by: Akihiro Sagawa
>
> dlls/winemac.drv/ime.c | 11 +++++------
>   1 file changed, 5 insertions(+), 6 deletions(-)

[Ken Thomases]

On Nov 16, 2017, at 9:12 AM, Akihiro Sagawa  wrote:
> This is winemac.drv port from winex11.drv.
> Please refer b8dc1e7cde64c212882958c0806b50911a360fb9.
> I've not tested this code, but I believe it works.

I can't confirm that this fixes bug 43904 on the Mac.  The behavior with the Mac driver seems pretty broken with or without your patch.  The composition happens in an external composition window, not inline in the editor.  The composition window is displaying just vertical bar characters (or the display is otherwise corrupted).  I can bring up the candidate window from the Mac input method and that displays normally.  If I pick "縋る" and confirm, the editor window just gets "EvEE" without your patch or "??EE" with it.

-Ken

[Akihiro Sagawa]

On Thu, 16 Nov 2017 13:27:04 -0600, Ken Thomases wrote:
> I can't confirm that this fixes bug 43904 on the Mac.  The behavior
> with the Mac driver seems pretty broken with or without your patch.

Thanks for testing and reviewing.
> The composition happens in an external composition window, not inline
> in the editor.  The composition window is displaying just vertical bar
> characters (or the display is otherwise corrupted).

This behavior is acceptable.  I'm not familiar with Mac environment, but
currently, Wine doesn't have inline composition text except edit control
(yet).
> I can bring up the candidate window from the Mac input method and
> that displays normally.  If I pick "縋る" and confirm, the editor
> window just gets "EvEE" without your patch or "??EE" with it.

I have a question about this point. Did you try the test in Japanese
locale? In other words, the editor expects codepage 932 as it uses ANSI
version functions. Thus, it doesn't work properly in English locale.
Could you show me a screenshot if you can?

Thanks in advance,
Akihiro Sagawa

[Ken Thomases]

On Nov 17, 2017, at 9:57 AM, Akihiro Sagawa  wrote:
> On Thu, 16 Nov 2017 13:27:04 -0600, Ken Thomases wrote:
> > I can't confirm that this fixes bug 43904 on the Mac.  The behavior
> > with the Mac driver seems pretty broken with or without your patch.
>
> Thanks for testing and reviewing.
> > The composition happens in an external composition window, not inline
> > in the editor.  The composition window is displaying just vertical bar
> > characters (or the display is otherwise corrupted).
>
> This behavior is acceptable.  I'm not familiar with Mac environment, but
> currently, Wine doesn't have inline composition text except edit control
> (yet).
> > I can bring up the candidate window from the Mac input method and
> > that displays normally.  If I pick "縋る" and confirm, the editor
> > window just gets "EvEE" without your patch or "??EE" with it.
>
> I have a question about this point. Did you try the test in Japanese
> locale? In other words, the editor expects codepage 932 as it uses ANSI
> version functions. Thus, it doesn't work properly in English locale.
> Could you show me a screenshot if you can?

OK, this was my error in testing.  I *did* try to test in the Japanese locale, but I messed it up.  I used "jp_JP.UTF-8" instead of "ja_JP.UTF-8".  I just retested with the proper locale and everything worked fine.  I also reverted your two patches and confirmed the original bug.

Sorry for the bother.

-Ken