Re: [PATCH] Do not run update-desktop-database on make install/uninstall

[Damjan Jovanovic]

Not all of us install Wine through a package manager, and
update-desktop-database is useful in that case. What that Makefile
should probably be doing instead, is calling update-desktop-database
only on the desktop directory where wine.desktop was just installed,
where it will succeed without root privileges, ie.:
        -$(UPDATE_DESKTOP_DATABASE) $(DESTDIR)$(datadir)/applications

Thank you
Damjan


On Sun, May 31, 2015 at 8:12 AM, Jerome Leclanche <jerome(a)leclan.ch> wrote:
> This causes root invocations of "make install" in a chroot to error
> It is the maintainer's or the package manager's job to run it, instead.
>
> Fixes bug #35191
>
> J. Leclanche

[PATCH] Do not run update-desktop-database on make install/uninstall

[Jerome Leclanche]

On 1 June 2015 at 10:50, Damjan Jovanovic <damjan.jov(a)gmail.com> wrote:
> Not all of us install Wine through a package manager, and
> update-desktop-database is useful in that case. What that Makefile
> should probably be doing instead, is calling update-desktop-database
> only on the desktop directory where wine.desktop was just installed,
> where it will succeed without root privileges, ie.:
>         -$(UPDATE_DESKTOP_DATABASE) $(DESTDIR)$(datadir)/applications
>
> Thank you
> Damjan

That's technically more correct but even worse, because building a
package (make install into a DESTDIR you will merely tarball) will
result in desktop db pollution. make install really shouldn't run
u-d-d at all - if you do make install and *want* to get desktop
associations, you can run it after make install, separately.

J. Leclanche