ntdll/cdrom : implement CDROM_Verify to work on Mac Os

[maury loïc]

Hello,

it's my first patch, and it implement the CDROM_Verify()
to work on Mac Os.

merci

Loïc

---
 dlls/ntdll/cdrom.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c
index 59f85a0..185f397 100644
--- a/dlls/ntdll/cdrom.c
+++ b/dlls/ntdll/cdrom.c
@@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd)
         return STATUS_SUCCESS;
     else
         return STATUS_NO_MEDIA_IN_DEVICE;
+#elif defined(__APPLE__)
+       return STATUS_SUCCESS;
 #else
     FIXME("not supported on this O/S\n");
     return STATUS_NOT_SUPPORTED;

[Ken Thomases]

Hi Loïc,

On Dec 30, 2010, at 4:20 AM, maury loïc wrote:
> it's my first patch, and it implement the CDROM_Verify()
> to work on Mac Os.

I think most people are going to need more explanation for why this is a legitimate way to implement this function on Mac OS X. :)

Cheers,
Ken

[maury loïc]

Hello Ken and the Wine community,

For what i understood, The function CDROM_Verify(), verify if the media is
present on the device, and Wine try to open
the device(in Mac Os case), before call the CDROM_Verify().

But Mac Os manage the device differently from the other Os. It create the
device, only if the media
is already present. Logically, CDROM_Verify() return success, because when
we are in CDROM_Verify()
we already know the device.

What do you think ?

merci

Loïc

On Thu, Dec 30, 2010 at 12:51 PM, Ken Thomases  wrote:
> Hi Loïc,
>
> On Dec 30, 2010, at 4:20 AM, maury loïc wrote:
> > it's my first patch, and it implement the CDROM_Verify()
> > to work on Mac Os.
>
> I think most people are going to need more explanation for why this is a
> legitimate way to implement this function on Mac OS X. :)
>
> Cheers,
> Ken

[Loïc Maury]

On Thu, Dec 30, 2010 at 11:20 AM, maury loïc  wrote:
> Hello,
>
> it's my first patch, and it implement the CDROM_Verify()
> to work on Mac Os.
>
> merci
>
> Loïc
>
> dlls/ntdll/cdrom.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/ntdll/cdrom.c b/dlls/ntdll/cdrom.c
> index 59f85a0..185f397 100644
> --- a/dlls/ntdll/cdrom.c
> +++ b/dlls/ntdll/cdrom.c
> @@ -1121,6 +1121,8 @@ static NTSTATUS CDROM_Verify(int dev, int fd)
>          return STATUS_SUCCESS;
>      else
>          return STATUS_NO_MEDIA_IN_DEVICE;
> +#elif defined(__APPLE__)
> -
>   return STATUS_SUCCESS;
>
> #else
>      FIXME("not supported on this O/S\n");
>      return STATUS_NOT_SUPPORTED;
> --
> 1.7.3.2

Hello Wine Community,

I see the status of the patch is "pending", there something wrong with the
patch ?

Thank you

Loïc