-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Looks good, thanks!
Wrt the testbot failures: It looks like CheckDeviceFormatConversion is in fact the right way to check this - I missed a sentence in the msdn page. I'll send a patch to handle this in this test and yuv_color_test. Real Windows drivers seem to agree with our interpretation of CheckDeviceFormatConversion.
(Sorry if this mail arrives twice. I think my mail server swallowed the last one.)
Am 2014-02-13 14:52, schrieb Martin Storsjo:
There are no public defines for the YV12 and NV12 formats, although they do seem to be supported on actual D3D on windows, at least on the one machine I tested on.
Removed unnecessary IDirect3DDevice9_SetFVF call.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-02-13 15:49, schrieb Stefan Dösinger:
Looks good, thanks!
Wrt the testbot failures: It looks like CheckDeviceFormatConversion is in fact the right way to check this
- I missed a sentence in the msdn page. I'll send a patch to handle
this in this test and yuv_color_test. Real Windows drivers seem to agree with our interpretation of CheckDeviceFormatConversion.
I've sent a patch (id 102467) that should take care of the testbot failures on the Windows 8 machine. The fix should conceptually work for your test as well.
I'm not entirely sure why Henri didn't ack your patches, but my guess it's because of the testbot failure or he was just waiting a day for the dust to settle. If not I'm sure he'll voice his concerns.
-
Stefan Dösinger