Re: [06/10] wintrust: Implement CryptCATOpen and CryptCATClose.

[Juan Lang]

Hi Hans, this is a really minor comment:

+struct cryptcat
+{
+    DWORD     magic;
+    HANDLE    msg;

msg's type should be HCRYPTMSG instead.

+        for (i = 0; i < cc->attr_count; i++)
+        {
+            if (!CryptMsgGetParam(hmsg, CMSG_ATTR_CERT_PARAM, i, NULL, &size))

Out of curiosity, how did you test this?
--Juan

[06/10] wintrust: Implement CryptCATOpen and CryptCATClose.

[Hans Leidekker]

On Monday 22 December 2008 16:59:29 Juan Lang wrote:
> +struct cryptcat
> +{
> - DWORD     magic;
> - HANDLE    msg;
>
> msg's type should be HCRYPTMSG instead.

Thanks for catching that.
> -
>    for (i = 0; i < cc->attr_count; i++)
> -
>    {
> -
>        if (!CryptMsgGetParam(hmsg, CMSG_ATTR_CERT_PARAM, i, NULL, &size))
>
> Out of curiosity, how did you test this?

That would be a question for Maarten since he mostly wrote this code.

-Hans

[06/10] wintrust: Implement CryptCATOpen and CryptCATClose.

[Juan Lang]

> > Out of curiosity, how did you test this?
>
> That would be a question for Maarten since he mostly wrote this code.

Well, last he asked me about it, I hadn't had a chance to look at
attribute certs in messages yet (they're stubbed out.)  That's why I
was curious ;-)
--Juan