Patchwatcher not reporting failures?

[Austin English]

Testing patchwatcher with a patch that simply removes two todo_wine's
should've caused some failures. Indeed, looking at the log:
cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20
cred.c:315: Test failed: expected NULL credentials but got 0x11d4ec
cred.c:328: Test failed: expected CredentialBlobSize of 0 but got 20
cred.c:328: Test failed: expected NULL credentials but got 0x11d4d0

it did. But patchwatcher shows an 'OK'. Can you take a look?

[Zachary Goldberg]

On Mon, Jun 1, 2009 at 5:34 AM, Austin English  wrote:
> Testing patchwatcher with a patch that simply removes two todo_wine's
> should've caused some failures. Indeed, looking at the log:
> cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20
> cred.c:315: Test failed: expected NULL credentials but got 0x11d4ec
> cred.c:328: Test failed: expected CredentialBlobSize of 0 but got 20
> cred.c:328: Test failed: expected NULL credentials but got 0x11d4d0
>
> it did. But patchwatcher shows an 'OK'. Can you take a look?
>
> --
> -Austin

Indeed.  I reset it, re ran your patch again and its still passing.
Unfortunately I cannot debug it today so I turned it off (so as to not
give people false data).  Hopefully I'll find time to fix it before
Wednesday otherwise sadly it won't be back for another 2 weeks when
I'm back from vacation.

-Zach

[André Hentschel]

Zachary Goldberg schrieb:
> On Mon, Jun 1, 2009 at 5:34 AM, Austin English  wrote:
> > Testing patchwatcher with a patch that simply removes two todo_wine's
> > should've caused some failures. Indeed, looking at the log:
> > cred.c:315: Test failed: expected CredentialBlobSize of 0 but got 20
> > cred.c:315: Test failed: expected NULL credentials but got 0x11d4ec
> > cred.c:328: Test failed: expected CredentialBlobSize of 0 but got 20
> > cred.c:328: Test failed: expected NULL credentials but got 0x11d4d0
> >
> > it did. But patchwatcher shows an 'OK'. Can you take a look?
> >
> > --
> > -Austin
>
> Indeed.  I reset it, re ran your patch again and its still passing.
> Unfortunately I cannot debug it today so I turned it off (so as to not
> give people false data).  Hopefully I'll find time to fix it before
> Wednesday otherwise sadly it won't be back for another 2 weeks when
> I'm back from vacation.
>
> -Zach

the logs say that it never compiles completely:
> make[2]: Leaving directory `/home/wine/patchwatcher-ro/wine-continuous-workdir/active/dlls/xinput1_3/tests'
> make[1]: Target `test' not remade because of errors.
> make[1]: Leaving directory `/home/wine/patchwatcher-ro/wine-continuous-workdir/active/dlls'
> make: *** [dlls/__test__] Error 2
> make: Target `test' not remade because of errors.
> Patchwatcher: difference versus baseline:
> Patchwatcher: no new errors!
> Patchwatcher:ok