Jacek Caban jacek@codeweavers.com writes:
Creating async object also validates and resets passed event, which (at least in some cases) should be done too early to queue the async. That's what following patches do for read and write to match error handling pattern.
Also, it seems nice to pass ready to use async object instead of async_data_t pointer to fd ops.
Maybe, but then please clean this up some more. Instead of adding a bunch of optional arguments, please split the functionality into separate functions. For instance, if create_async() is not always queuing, then make queuing a separate step in all cases. Also if we pass the async object we shouldn't need to pass the async data or iosb.