Re: msxml3: Use correct string length in saxreader_get_cdata_chunk

[Nikolay Sivov]

On 05.10.2017 15:59, Piotr Caban wrote:
> @@ -1972,6 +1972,7 @@ static BSTR saxreader_get_cdata_chunk(const xmlChar *str, int len)
>      BSTR bstr = bstr_from_xmlCharN(str, len), ret;
>      WCHAR *ptr;
> - len = SysStringLen(bstr);

Hi.

Just making sure I understand this correctly, the issue is that we're
using length counted in xmlChars as WCHAR length?

msxml3: Use correct string length in saxreader_get_cdata_chunk

[Piotr Caban]

Hi Nikolay,

On 10/06/17 07:53, Nikolay Sivov wrote:
> On 05.10.2017 15:59, Piotr Caban wrote:
> > @@ -1972,6 +1972,7 @@ static BSTR saxreader_get_cdata_chunk(const xmlChar *str, int len)
> >       BSTR bstr = bstr_from_xmlCharN(str, len), ret;
> >       WCHAR *ptr;
> > - len = SysStringLen(bstr);
>
> Hi.
>
> Just making sure I understand this correctly, the issue is that we're
> using length counted in xmlChars as WCHAR length?

Yes (it's fixing an application that has 2-bytes UTF-8 characters in 
CDATA block).

msxml3: Use correct string length in saxreader_get_cdata_chunk

[Nikolay Sivov]

On 06.10.2017 12:19, Piotr Caban wrote:
> Hi Nikolay,
>
> On 10/06/17 07:53, Nikolay Sivov wrote:
> > On 05.10.2017 15:59, Piotr Caban wrote:
> > > @@ -1972,6 +1972,7 @@ static BSTR saxreader_get_cdata_chunk(const
> > > xmlChar *str, int len)
> > >       BSTR bstr = bstr_from_xmlCharN(str, len), ret;
> > >       WCHAR *ptr;
> > >   +    len = SysStringLen(bstr);
> >
> > Hi.
> >
> > Just making sure I understand this correctly, the issue is that we're
> > using length counted in xmlChars as WCHAR length?
>
> Yes (it's fixing an application that has 2-bytes UTF-8 characters in
> CDATA block).

Great, thanks.