Wine staging 3.13 release

[Alistair Leslie-Hughes]

Binary packages for various distributions will be available from:
https://www.winehq.org/download

Summary of the past few weeks
* Rebased to current wine 3.13 (880 patches are applied to wine vanilla)
* Reviewed and upstreamed patches.

Updated patchsets
* xaudio2 WMA support.
* kernelbase-PathCchCombineEx
* winepulse-PulseAudio_Support

Added
* [44888] Implement WINED3DFMT_B8G8R8X8_UNORM to WINED3DFMT_L8_UNORM
conversion
* [36763] Rogue Squadron 3D 1.3: Crashes with game resolutions above 640x480
* [28282] Sound constantly crackling in lot of games

Where can you help
* Run Steam/Battle.net/UPlay.
* Try you favorite game.
* Test your favorite applications.
* Steal staging patches and get them accepted upstream.

As always, if you find a bug, please report it via
https://bugs.winehq.org

Best Regards
 Alistair.

[Kai Krakow]

Hello!

2018-07-22 0:23 GMT+02:00 Alistair Leslie-Hughes :
> Binary packages for various distributions will be available from:
> https://www.winehq.org/download
>
> Summary of the past few weeks
> - Rebased to current wine 3.13 (880 patches are applied to wine vanilla)
> - Reviewed and upstreamed patches.
>
> Updated patchsets
> - xaudio2 WMA support.
> - kernelbase-PathCchCombineEx
> - winepulse-PulseAudio_Support

This new winepulse patchset seems to introduce very bad audio
distortion for me. Sound is played at around half of its original
speed with what sounds like empty buffers alternating with filled
buffers. I'm currently cross-checking by reverting to the old
patchset.

Changing PULSE_LATENCY_MSEC only introduces visible audio lag but
doesn't fix the distortion. This was different with older releases
(before native pulseaudio support).

Running pulseaudio 11.1 here usually without setting
PULSE_LATENCY_MSEC. My setup worked with both USB audio and builtin
audio just fine until now, switching audio sinks and sources also
worked.

If there's anything I can help with diagnosing this, let me know.

Thanks,
Kai

[Andrew Eikum]

On Sun, Jul 22, 2018 at 04:19:07PM +0200, Kai Krakow wrote:
> This new winepulse patchset seems to introduce very bad audio
> distortion for me. Sound is played at around half of its original
> speed with what sounds like empty buffers alternating with filled
> buffers. I'm currently cross-checking by reverting to the old
> patchset.
>
> Changing PULSE_LATENCY_MSEC only introduces visible audio lag but
> doesn't fix the distortion. This was different with older releases
> (before native pulseaudio support).
>
> Running pulseaudio 11.1 here usually without setting
> PULSE_LATENCY_MSEC. My setup worked with both USB audio and builtin
> audio just fine until now, switching audio sinks and sources also
> worked.
>
> If there's anything I can help with diagnosing this, let me know.

Thanks Kai, this is great feedback. Is every application affected, or
only some applications? The patch is intended to improve audio with
USB hardware and remove the need for hacks like the PULSE_LATENCY_MSEC
override, using winealsa on PA systems, or disabling PA altogether.

Could you send me a short log with the channels from
https://wiki.winehq.org/Sound along with a description of your audio
hardware? Either private email or on bug 28282 is great.

Thanks,
Andrew

[Kai Krakow]

2018-07-23 14:16 GMT+02:00 Andrew Eikum :
> On Sun, Jul 22, 2018 at 04:19:07PM +0200, Kai Krakow wrote:
> > This new winepulse patchset seems to introduce very bad audio
> > distortion for me. Sound is played at around half of its original
> > speed with what sounds like empty buffers alternating with filled
> > buffers. I'm currently cross-checking by reverting to the old
> > patchset.
> >
> > Changing PULSE_LATENCY_MSEC only introduces visible audio lag but
> > doesn't fix the distortion. This was different with older releases
> > (before native pulseaudio support).
> >
> > Running pulseaudio 11.1 here usually without setting
> > PULSE_LATENCY_MSEC. My setup worked with both USB audio and builtin
> > audio just fine until now, switching audio sinks and sources also
> > worked.
> >
> > If there's anything I can help with diagnosing this, let me know.
>
> Thanks Kai, this is great feedback. Is every application affected, or
> only some applications?

As far as I can tell, all apps are affected. Before I used this
patchset, only some apps were affected. With the old patchset,
everything is perfectly smooth except when the system is under heavy
load, I can here some faint cracking in the sound which was mostly
fixed by raising priorities and switching to a CK kernel, I believe.
But I'm not sure.
> The patch is intended to improve audio with
> USB hardware and remove the need for hacks like the PULSE_LATENCY_MSEC
> override, using winealsa on PA systems, or disabling PA altogether.

I'm not using winealsa or other hacks, I always think it should work
without hacks. I'm not using PULSE_LATENCY_MSEC because it seems to
freeze some games during sound init. And it was also only a remnant of
the old workaround I had to use before. So it's removed for quite a
while now.
> Could you send me a short log with the channels from
> https://wiki.winehq.org/Sound along with a description of your audio
> hardware? Either private email or on bug 28282 is great.

I guess that some more configuration option might have an impact.
First, there's a recommendation to increase kernel sound buffers to
2048 (instead of default 64) when using pulseaudio, so I did this. I'm
also using not quite default pulseaudio configuration.

So, I'll bundle up a package of these including the logs. It may take
me a few days, tho.

Thanks,
Kai

[Andrew Eikum]

On Mon, Jul 23, 2018 at 02:26:46PM +0200, Kai Krakow wrote:
> > Could you send me a short log with the channels from
> > https://wiki.winehq.org/Sound along with a description of your audio
> > hardware? Either private email or on bug 28282 is great.
>
> I guess that some more configuration option might have an impact.
> First, there's a recommendation to increase kernel sound buffers to
> 2048 (instead of default 64) when using pulseaudio, so I did this. I'm
> also using not quite default pulseaudio configuration.

If you made those changes just for Wine, then I'd suggest reverting
them and trying with a stock setup. If you have those changes for
other reasons, then we can try to get them to work with Wine. A
specific description of the changes would be helpful, so I can try to
reproduce on my end.
> So, I'll bundle up a package of these including the logs. It may take
> me a few days, tho.

Cool, thanks. I'm happy to help get this working again. Going through
staging will help work out the kinks :)

Andrew

[Kai Krakow]

2018-07-23 14:30 GMT+02:00 Andrew Eikum :
> On Mon, Jul 23, 2018 at 02:26:46PM +0200, Kai Krakow wrote:
> > > Could you send me a short log with the channels from
> > > https://wiki.winehq.org/Sound along with a description of your audio
> > > hardware? Either private email or on bug 28282 is great.
> >
> > I guess that some more configuration option might have an impact.
> > First, there's a recommendation to increase kernel sound buffers to
> > 2048 (instead of default 64) when using pulseaudio, so I did this. I'm
> > also using not quite default pulseaudio configuration.
>
> If you made those changes just for Wine, then I'd suggest reverting
> them and trying with a stock setup. If you have those changes for
> other reasons, then we can try to get them to work with Wine. A
> specific description of the changes would be helpful, so I can try to
> reproduce on my end.

I did this long before using Wine, tho it looks like I increased it
from recommended 2048 to 4096 out of desperation:
> From "make menuconfig":
> CONFIG_SND_HDA_PREALLOC_SIZE:
>
> Specifies the default pre-allocated buffer-size in kB for the
> HD-audio driver.  A larger buffer (e.g. 2048) is preferred
> for systems using PulseAudio.  The default 64 is chosen just
> for compatibility reasons.
>
> Note that the pre-allocation size can be changed dynamically
> via a proc file (/proc/asound/card*/pcm*/sub*/prealloc), too.
>
> Symbol: SND_HDA_PREALLOC_SIZE [=4096]
> Type  : integer
> Range : [0 32768]
> Prompt: Pre-allocated buffer size for HD-audio driver
> Location:
>   -> Device Drivers
>     -> Sound card support (SOUND [=m])
>       -> Advanced Linux Sound Architecture (SND [=m])
>  Defined at sound/hda/Kconfig:18
>  Depends on: SOUND [=m] && !UML && SND [=m]

I think this recommendation could be default in many distributions.
I'm using Gentoo here, so I don't know what setting conventional
distributions are using.

I could revert the pulseaudio changes, tho. But I think all are pretty
harmless except maybe sampling rates:

$ egrep -v "^(;|$|#)" /etc/pulse/daemon.conf
realtime-scheduling = yes
realtime-priority = 80
enable-lfe-remixing = yes
rlimit-rtprio = 90
default-sample-format = s24le
default-sample-rate = 96000
alternate-sample-rate = 48000
default-sample-channels = 6
default-channel-map =
front-left,front-right,rear-left,rear-right,front-center,lfe
> > So, I'll bundle up a package of these including the logs. It may take
> > me a few days, tho.
>
> Cool, thanks. I'm happy to help get this working again. Going through
> staging will help work out the kinks :)

Regards,
Kai