Re: More checks when loading the driver

[Eric Pouech]

Uwe Bonnes wrote:
> Changelog:
>    wine/dlls/winmm/lolvldrv.c: MMDRV_Install
>    Check for failing DRIVER_FindFromHDrvr

this doesn't seem right to me: either the loading fails and we shouldn't 
get a valid handle, or it succeeds and we should be able to find it
there's must be something wrong elsewhere
could you please send a -debugmsg +driver,+module,+winmm to see what 
happens ?

TIA

More checks when loading the driver

[Uwe Bonnes]

> > > > > "Eric" == Eric Pouech  writes:

Eric> Uwe Bonnes wrote:
    >> Changelog: wine/dlls/winmm/lolvldrv.c: MMDRV_Install Check for
    >> failing DRIVER_FindFromHDrvr
    Eric> this doesn't seem right to me: either the loading fails and we
    Eric> shouldn't get a valid handle, or it succeeds and we should be able
    Eric> to find it there's must be something wrong elsewhere could you
    Eric> please send a -debugmsg +driver,+module,+winmm to see what happens
    Eric> ?

Sorry,

the error no longer exists. I guess some registry entry was corrupt and a
successfull  run corrected it later.

However I see a lot of check after  DRIVER_FindFromHDrvr() in other parts of
the code...

Bye

More checks when loading the driver

[Eric Pouech]

> the error no longer exists. I guess some registry entry was corrupt and a
> successfull  run corrected it later.

this also could happen with stack corruption
> However I see a lot of check after  DRIVER_FindFromHDrvr() in other parts of
> the code...

they are not checks, but rather discoveries of the actual capabilities 
of the driver

A+