Re: configure.ac: remove an extraneous semicolon (Clang)

[Ken Thomases]

On Jan 30, 2012, at 10:09 PM, Austin English wrote:
> @@ -1723,7 +1723,7 @@ then
>    saved_CFLAGS="$CFLAGS"
>    CFLAGS="$CFLAGS -Wlogical-op -Werror"
>    AC_CACHE_CHECK([for broken string.h that generates warnings with -Wlogical-op], ac_cv_c_logicalop_noisy,
> -
>  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n);}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes]))
> -
>  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n)}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes]))
> CFLAGS="$saved_CFLAGS"
>  if test "$ac_cv_c_logicalop_noisy" = "no"
>  then

That doesn't look extraneous to me.

Also, static analysis of the configure test programs seems like it would produce tons of noise.  Those are often not sane programs by normal standards.

Regards,
Ken

configure.ac: remove an extraneous semicolon (Clang)

[Austin English]

On Mon, Jan 30, 2012 at 23:21, Ken Thomases  wrote:
> On Jan 30, 2012, at 10:09 PM, Austin English wrote:
> > @@ -1723,7 +1723,7 @@ then
> >    saved_CFLAGS="$CFLAGS"
> >    CFLAGS="$CFLAGS -Wlogical-op -Werror"
> >    AC_CACHE_CHECK([for broken string.h that generates warnings with -Wlogical-op], ac_cv_c_logicalop_noisy,
> > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n);}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes]))
> > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[#include <string.h>]], [[char*f(const char *h,char n) {return strchr(h,n)}]])],[ac_cv_c_logicalop_noisy=no],[ac_cv_c_logicalop_noisy=yes]))
> >
> > CFLAGS="$saved_CFLAGS"
> >    if test "$ac_cv_c_logicalop_noisy" = "no"
> >    then
>
> That doesn't look extraneous to me.

You're right, misread the output from config.log, my mistake.
> Also, static analysis of the configure test programs seems like it would produce tons of noise.  Those are often not sane programs by normal standards.

Actually, it's mostly clean using Clang..