Regression in comctl32 Treeview (breaks Filezilla)

[Hannu Valtonen]

Hi,

The following patch:

ChangeSet ID:	15259
CVSROOT:	/opt/cvs-commit
Module name:	wine
Changes by:	[e-mail]	2005/01/07 09:34:25

Modified files:
    dlls/comctl32  : treeview.c

Log message:
    Crestez Leonard 
    Fix bug with Treeview_SelectItem reselecting the same item.

Patch: http://cvs.winehq.org/patch.py?id=15259

Old revision  New revision  Changes     Path
 1.160         1.161         +0 -3       wine/dlls/comctl32/treeview.c

Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The 
way to reproduce it is to go to the Site manager and click the "New 
site" button. (Doesn't work even with latest CVS)

Without the check which the patch removes,

if (prevSelect == newSelect)
         return FALSE;

The dialog goes to an infinite loop. (you can exit it if you just hold 
the ESC-key down for long enough)

I have no idea whether the rationale Leonard provided with his patch is 
correct, but it does break Filezilla.

The binary file for Filezilla can be gotten from: 
http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?down...
and the source file from:
http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downlo...

I would appreciate it if some comctl32 messaging guru could step up and 
take look at this problem

Regression in comctl32 Treeview (breaks Filezilla, mIRC)

[Hannu Valtonen]

Hannu Valtonen wrote:
> Hi,
>
> The following patch:
>
> ChangeSet ID:    15259
> CVSROOT:    /opt/cvs-commit
> Module name:    wine
> Changes by:    [e-mail]    2005/01/07 09:34:25
>
> Modified files:
>     dlls/comctl32  : treeview.c
> Log message:
>     Crestez Leonard 
>     Fix bug with Treeview_SelectItem reselecting the same item.
>
> Patch: http://cvs.winehq.org/patch.py?id=15259
>
> Old revision  New revision  Changes     Path
> 1.160         1.161         +0 -3       wine/dlls/comctl32/treeview.c
>
> Breaks Filezilla's (filezilla.sourceforge.net) add new site dialog. The 
> way to reproduce it is to go to the Site manager and click the "New 
> site" button. (Doesn't work even with latest CVS)
>
> Without the check which the patch removes,
> if (prevSelect == newSelect)
>     return FALSE;
>
> The dialog goes to an infinite loop. (you can exit it if you just hold 
> the ESC-key down for long enough)
>
> I have no idea whether the rationale Leonard provided with his patch is 
> correct, but it does break Filezilla.
>
> The binary file for Filezilla can be gotten from: 
> http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_setup.exe?down...
>
> and the source file from:
> http://prdownloads.sourceforge.net/filezilla/FileZilla_2_2_10_src.zip?downlo...
>
> I would appreciate it if some comctl32 messaging guru could step up and 
> take look at this problem

Heh, my friend complained about his mIRC not working either. The same 
patch breaks mIRC as well. i.e. if you connect then as soon as you're 
about to join a channel the program freezes completely.

Any comctl32 guru want to take a look?

- Hannu Valtonen
[e-mail]