Re: [PATCH 3/7] wined3d: Add support for WINED3DFMT_R8G8B8A8_UINT textures.

[Henri Verbeet]

This introduces GL errors:
    err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from Post-pixelshader blending check @ utils.c / 1905
    err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from Post-pixelshader blending check @ utils.c / 1905
    err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from Post-pixelshader blending check @ utils.c / 1905
    err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from Post-pixelshader blending check @ utils.c / 1905
    err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from Post-pixelshader blending check @ utils.c / 1905
    err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
(0x502) from Post-pixelshader blending check @ utils.c / 1905

I didn't check if that's the issue here, but in the longer term we'll
probably need to add channel type information to the formats[] table.
E.g. look at places that currently use WINED3DFMT_FLAG_FLOAT.

[PATCH 3/7] wined3d: Add support for WINED3DFMT_R8G8B8A8_UINT textures.

[Józef Kucia]

On Fri, Jan 22, 2016 at 2:18 PM, Henri Verbeet  wrote:
> This introduces GL errors:
>     err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from Post-pixelshader blending check @ utils.c / 1905
>     err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from Post-pixelshader blending check @ utils.c / 1905
>     err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from Post-pixelshader blending check @ utils.c / 1905
>     err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from Post-pixelshader blending check @ utils.c / 1905
>     err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from Post-pixelshader blending check @ utils.c / 1905
>     err:d3d:check_fbo_compat >>>>>>>>>>>>>>>>> GL_INVALID_OPERATION
> (0x502) from Post-pixelshader blending check @ utils.c / 1905
>
> I didn't check if that's the issue here, but in the longer term we'll
> probably need to add channel type information to the formats[] table.
> E.g. look at places that currently use WINED3DFMT_FLAG_FLOAT.

I'm sorry for missing these errors. I probably missed them because
they don't appear with all drivers. glGetTexImage() fails for integer
textures in check_fbo_compat() because we ask for normalized format
(GL_BGRA). Either way, we shouldn't check blending for integer texture
formats.