Re: [PATCH] gdi32: Report unsubstituted font face names. (try 4)

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=6914

Your paranoid android.

=== w2000pro (32 bit font) ===
font.c:4756: Test failed: expected MS Shell Dlg got Microsoft Sans Serif
font.c:4765: Test failed: expected MS Shell Dlg 2 got Tahoma Bold

=== wxppro (32 bit font) ===
font.c:4756: Test failed: expected MS Shell Dlg got Microsoft Sans Serif
font.c:4765: Test failed: expected MS Shell Dlg 2 got Tahoma Bold

=== w2008s64 (32 bit font) ===
font.c:4756: Test failed: expected MS Shell Dlg got Microsoft Sans Serif
font.c:4765: Test failed: expected MS Shell Dlg 2 got Tahoma

=== w8 (32 bit font) ===
font.c:4756: Test failed: expected MS Shell Dlg got Microsoft Sans Serif
font.c:4765: Test failed: expected MS Shell Dlg 2 got Tahoma

=== w2008s64 (64 bit font) ===
font.c:4756: Test failed: expected MS Shell Dlg got Microsoft Sans Serif
font.c:4765: Test failed: expected MS Shell Dlg 2 got Tahoma

[PATCH] gdi32: Report unsubstituted font face names. (try 4)

[Alex Henrie]

So it looks like the full name is supposed to reflect the real font's
name after all. Does this mean that we can just commit
http://source.winehq.org/patches/data/104434 ?

-Alex

[PATCH] gdi32: Report unsubstituted font face names. (try 4)

[Alexandre Julliard]

Alex Henrie  writes:
> So it looks like the full name is supposed to reflect the real font's
> name after all. Does this mean that we can just commit
> http://source.winehq.org/patches/data/104434 ?

Looks like it, but please resend a version that also includes your new
tests.