Patch : fixme:msvcrt:MSVCRT__sopen : pmode 0x01a0 ignored

[Erik de Castro Lopo]

Hi all,

My interest in Wine is mainly because it allows me run the test suite
for my projects when I use the Linux -> windows MinGW compiler.

Currently, the programs in my test suite spit out a lot of fixme
warnings like:

fixme:msvcrt:MSVCRT__sopen : pmode 0x01a0 ignored

I've tracked this down in the code to the function in
dlls/msvcrt/file.c.

The patch below removes this fixme warning. I beleive that simply removing
the warning is valid in this case because the variable being warned about,
pmode, is not used after the warning. In fact, the only use of this variable
is the FIXME or WARN messages.

Cheers,
Erik

--- dlls/msvcrt/file.c~ 2008-03-25 23:42:47.000000000 +1100
+++ dlls/msvcrt/file.c  2008-03-25 23:44:14.000000000 +1100
@@ -1442,11 +1442,6 @@
       pmode = va_arg(ap, int);
     va_end(ap);

-    if(pmode & ~(MSVCRT__S_IREAD | MSVCRT__S_IWRITE))
-      FIXME(": pmode 0x%04x ignored\n", pmode);
-    else
-      WARN(": pmode 0x%04x ignored\n", pmode);
-
     if (oflags & MSVCRT__O_EXCL)
       creation = CREATE_NEW;
     else if (oflags & MSVCRT__O_TRUNC)

[Juan Lang]

> The patch below removes this fixme warning. I beleive that simply removing
>  the warning is valid in this case because the variable being warned about,
>  pmode, is not used after the warning. In fact, the only use of this variable
>  is the FIXME or WARN messages.

Don't you think the reason for the warning is that pmode isn't used
when perhaps it should be?  Removing it without understanding it isn't
a help.
--Juan