Re: [PATCH 06/12] [WineDbg]: rewrite auto mode

[Alexandre Julliard]

Eric Pouech  writes:
> @@ -880,7 +861,14 @@ enum dbg_start    dbg_active_launch(int 
>   */
>  enum dbg_start dbg_active_auto(int argc, char* argv[])
>  {
> - HANDLE      hFile;
> - argc--; argv++;
> - dbg_action_mode = automatic_mode;
> - return dbg_active_attach(argc, argv);
> - hFile = parser_generate_command_file("echo Modules:", "info share",
> -
>                                     "echo Threads:", "info threads",
> -
> 			 NULL);
> - if (hFile == INVALID_HANDLE_VALUE || !dbg_active_attach(argc, argv))
> -
>    return FALSE;
> - dbg_main_loop(hFile);
> - return TRUE;
>
> }

This completely breaks auto mode, because dbg_active_attach returns an
enum dbg_start, not a boolean. There's the same mistake in the next
patch too.

[PATCH 06/12] [WineDbg]: rewrite auto mode

[Eric Pouech]

Alexandre Julliard wrote:
> Eric Pouech  writes:
> > @@ -880,7 +861,14 @@ enum dbg_start    dbg_active_launch(int 
> >  */
> > enum dbg_start dbg_active_auto(int argc, char* argv[])
> > {
> > - HANDLE      hFile;
> > - argc--; argv++;
> > - dbg_action_mode = automatic_mode;
> > - return dbg_active_attach(argc, argv);
> > - hFile = parser_generate_command_file("echo Modules:", "info share",
> > -
> >                                     "echo Threads:", "info threads",
> > -
> > 			 NULL);
> > - if (hFile == INVALID_HANDLE_VALUE || !dbg_active_attach(argc, argv))
> > -
> >    return FALSE;
> > - dbg_main_loop(hFile);
> > - return TRUE;
> >
> > }
>
> This completely breaks auto mode, because dbg_active_attach returns an
> enum dbg_start, not a boolean. There's the same mistake in the next
> patch too.

grr last minute changes, not correctly forwarded on all set
BTW, there's the same one in the previous patch. I'll send the whole lot 
(starting with the regression's fix) later on tonight.
A+