[PATCH] kernel32/tests: Remove an unused assignment in the comm test.

[Francois Gouget]

Signed-off-by: Francois Gouget 
---
 dlls/kernel32/tests/comm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/kernel32/tests/comm.c b/dlls/kernel32/tests/comm.c
index 97da932d6cb..a43a290947f 100644
--- a/dlls/kernel32/tests/comm.c
+++ b/dlls/kernel32/tests/comm.c
@@ -907,7 +907,6 @@ static void test_waittxempty(void)
             S(U(ovl_write)).Offset = 0;
             S(U(ovl_write)).OffsetHigh = 0;
             ovl_write.hEvent = CreateEventW(NULL, TRUE, FALSE, NULL);
-            before = GetTickCount();
             SetLastError(0xdeadbeef);
             res = WriteFile(hcom, tbuf, sizeof(tbuf), &bytes, &ovl_write);
             ok((!res && GetLastError() == ERROR_IO_PENDING) || (res && bytes == sizeof(tbuf)),

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=60590

Your paranoid android.

=== w1064v1809 (32 bit report) ===

kernel32:
comm.c:859: Test failed: WaitCommEvent failed with a timeout
comm.c:880: Test failed: WaitCommEvent error 0
comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:886: Test failed: WaitCommEvent used 1516 ms for waiting

=== w1064v1809_zh_CN (32 bit report) ===

kernel32:
comm.c:859: Test failed: WaitCommEvent failed with a timeout
comm.c:880: Test failed: WaitCommEvent error 0
comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:886: Test failed: WaitCommEvent used 1500 ms for waiting

=== w1064v1507 (64 bit report) ===

kernel32:
comm.c:859: Test failed: WaitCommEvent failed with a timeout
comm.c:880: Test failed: WaitCommEvent error 0
comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
comm.c:886: Test failed: WaitCommEvent used 1516 ms for waiting

=== debian10 (32 bit Japanese:Japan report) ===

kernel32:
comm.c:918: Test failed: OutQueue should not be empty

=== debian10 (32 bit Chinese:China report) ===

kernel32:
comm.c:918: Test failed: OutQueue should not be empty

[Francois Gouget]

On Thu, 21 Nov 2019, Marvin wrote:
[...]
> === w1064v1809 (32 bit report) ===
> === w1064v1809_zh_CN (32 bit report) ===
> === w1064v1507 (64 bit report) ===
>
> kernel32:
> comm.c:859: Test failed: WaitCommEvent failed with a timeout
> comm.c:880: Test failed: WaitCommEvent error 0
> comm.c:881: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0
> comm.c:886: Test failed: WaitCommEvent used 1516 ms for waiting

These are preexisting random failures:
https://bugs.winehq.org/show_bug.cgi?id=47873

I suspect they are caused by the same issue the one below. Having the 
TestBot better deal with random failures would help but the call 
duration (1500, 1516 ms) may make it harder for the TestBot to identify 
them as preexisting failures. Maybe such values should be clearly 
identified, for instance by enclosing in double braces "used ((1500)) ms" 
so the TestBot would know to ignore that part when comparing failures.
> === debian10 (32 bit Japanese:Japan report) ===
> === debian10 (32 bit Chinese:China report) ===
>
> kernel32:
> comm.c:918: Test failed: OutQueue should not be empty

This one is also a known failure. It happens because QEmu ignores the 
serial port's baud rate:
https://bugs.winehq.org/show_bug.cgi?id=48108